NMS-13540: Highlight search terms in result page#21
Open
Conversation
fooker
force-pushed
the
jira/NMS-13540
branch
7 times, most recently
from
a89c0a3 to
9091c08
Compare
Bonrob2
reviewed
Dec 14, 2022
Contributor
Bonrob2
left a comment
Bonrob2
left a comment
There was a problem hiding this comment.
Not able to test this, but thanks for doing all the work.
fooker
force-pushed
the
jira/NMS-13540
branch
4 times, most recently
from
98fafa7 to
3bacf95
Compare
fooker
force-pushed
the
jira/NMS-13540
branch
from
3bacf95 to
15be42e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the version of
antora-lunr-extensionto our own for which implements the required functionality: https://github.com/opennms-forge/antora-lunr-extension.To use the changes in
antora-lunr-extension, the builder image has to be updated, too.See opennms-forge/opennms-base-container#26.
In addition, a PR for upstream has been created: https://gitlab.com/antora/antora-lunr-extension/-/merge_requests/90.